fstream icon indicating copy to clipboard operation
fstream copied to clipboard

Fixed issue #14 with getChildProps setting follow. from this.follow to this....

Open AdamMagaluk opened this issue 12 years ago • 8 comments

Fixes issue #14 here with not following directories that are symlinks. Not sure what the intended design was.

AdamMagaluk avatar Oct 04 '13 13:10 AdamMagaluk

This looks like a simple typo fix, any chance this PR might get included in a v0.1.26 minor release?

cbraynor avatar Jun 03 '14 03:06 cbraynor

Hi @zkat, I just wanted to ping on this PR. Assuming that following nested symlinks is the intended behavior, is there any reason this (once rebased) can't be merged?

dtex avatar Oct 13 '15 17:10 dtex

Hi @zkat and @othiym23 just wanted to ping on this again. Sorry to be a squeaky wheel.

dtex avatar Oct 23 '15 19:10 dtex

I need to write tests for this :<

zkat avatar Oct 30 '15 22:10 zkat

HI, @othiym23 Is there anything I can do to help with this? I'd be willing to write some tests if y'all have something I can reference to see how you want them.

p.s. We met at Cascadia, I was the guy with the hexapod.

dtex avatar Dec 17 '15 22:12 dtex

Hey guys,

is there any progress regarding this PR? Need this to use symbolic links in firebase (see https://github.com/firebase/firebase-tools/issues/22).

Cheers

hpawe01 avatar May 09 '17 15:05 hpawe01

@zkat @othiym23 can you address this (seemingly simple) issue. Since firebase-tools depend on this library, this completely blocks any use of symlinks in firebase projects(!).

Firebase Issue: https://github.com/firebase/firebase-tools/issues/22

image

D1no avatar Sep 14 '17 15:09 D1no

I cannot believe this PR has been open for 6 years, contains a single line diff, and still hasn't been merged...

I mean, I'm all for writing tests, but guys come on. As has been mentioned firebase-tools depends upon this repo and for those of us looking to structure our code in a mono-repo we need the ability to use symlinks.

If there is anything myself or any of the community members can do to get this fixed upstream please lmk.

Rojuinex avatar Sep 24 '19 18:09 Rojuinex