fstream-npm icon indicating copy to clipboard operation
fstream-npm copied to clipboard

npmignore entries trump files entries

Open zkat opened this issue 9 years ago • 2 comments
trafficstars

Previously, files were treated as negated-negated ignores. This made it fairly tricky to control whether files or .npmignore took priority when deciding whether a file should be included.

With this change, files are included through a more explicit process, and any applicable ignores will trump specific files.

zkat avatar Apr 01 '16 22:04 zkat

Coverage Status

Coverage decreased (-2.4%) to 81.169% when pulling 7e2d04655edf07d5d98f9a0366773b02f1e44577 on zkat/npmignore-trumps-files into d57b6b24f91156067f73417dd8785c6312bfc75f on master.

coveralls avatar Apr 01 '16 22:04 coveralls

Has this recently been implemented somewhere? Because this fix has (in the last couple of days) started breaking things where we have dist in our files:[] list but also in .gitignore and running npm publish results in modules without any (code) content. Having to maintain duplicate ignore lists (only one without "dist") is an ugly thing to foist on the users IMO.

sophistifunk avatar Jun 27 '17 23:06 sophistifunk