fstream-npm icon indicating copy to clipboard operation
fstream-npm copied to clipboard

fstream-npm: do not rename *.gyp twice

Open indutny opened this issue 9 years ago • 6 comments
trafficstars

Do not rename multiple *.gyp files to binding.gyp . As a side-effect, no .gyp files will be renamed if binding.gyp is present.

Fix: https://github.com/npm/npm/issues/8411

indutny avatar Feb 25 '16 23:02 indutny

cc @othiym23 I'm not exactly sure if this kind of sort function is acceptable. Other solution may be to set this _renameGyp flag from the sort, if it will see binding.gyp. However, it seems strange too.

Please let me know what you think about it.

indutny avatar Feb 25 '16 23:02 indutny

Does this accomplish the same thing as https://github.com/npm/fstream-npm/pull/16 does?

kenany avatar Feb 26 '16 01:02 kenany

No, @KenanY. It is a slightly more compatible solution, IMO. It will still rename .gyp files, but only if there are no binding.gyp, and only the first one of .gyp in any case.

indutny avatar Feb 26 '16 01:02 indutny

Ah okay :)

kenany avatar Feb 26 '16 01:02 kenany

Dupe of https://github.com/npm/fstream-npm/pull/16?

mikemorris avatar Mar 16 '16 18:03 mikemorris

@mikemorris they are different, see https://github.com/npm/fstream-npm/pull/18#issuecomment-189067408

indutny avatar Mar 16 '16 21:03 indutny