fstream-npm
fstream-npm copied to clipboard
fstream-npm: do not rename *.gyp twice
Do not rename multiple *.gyp files to binding.gyp . As a side-effect, no .gyp files will be renamed if binding.gyp is present.
Fix: https://github.com/npm/npm/issues/8411
cc @othiym23 I'm not exactly sure if this kind of sort function is acceptable. Other solution may be to set this _renameGyp flag from the sort, if it will see binding.gyp. However, it seems strange too.
Please let me know what you think about it.
Does this accomplish the same thing as https://github.com/npm/fstream-npm/pull/16 does?
No, @KenanY. It is a slightly more compatible solution, IMO. It will still rename .gyp files, but only if there are no binding.gyp, and only the first one of .gyp in any case.
Ah okay :)
Dupe of https://github.com/npm/fstream-npm/pull/16?
@mikemorris they are different, see https://github.com/npm/fstream-npm/pull/18#issuecomment-189067408