cli icon indicating copy to clipboard operation
cli copied to clipboard

fix:npm install does not detect engine-compatible package properly

Open kchindam-infy opened this issue 1 year ago • 1 comments

The fix addresses an issue where the engine-strict flag is not enforced during the version resolution phase in npm. When engine-strict is enabled, npm should only install package versions that are compatible with the current Node.js version, as specified in the package's engines field. However, prior to this fix, npm did not consider the engines.node field during version resolution, potentially leading to the installation of incompatible package versions.

Enforces engine-strict During Version Resolution: Modifies the build-ideal-tree.js file to ensure that when engine-strict is enabled, npm filters out package versions that are incompatible with the current Node.js version before selecting which version to install.

References

kchindam-infy avatar Oct 09 '24 18:10 kchindam-infy

This behavior belongs in pacote. It's already doing a lot of logic to pick the right manifest based on the spec. If fact it may actually be npm-pick-manifest that needs to be fixed here. https://github.com/npm/pacote/blob/35529738b00143a05d61ad361d30a7ea26c87bed/lib/registry.js#L130

wraithgar avatar Oct 09 '24 18:10 wraithgar

Replaced by https://github.com/npm/npm-pick-manifest/pull/148. Close?

mbtools avatar Jan 19 '25 19:01 mbtools