cli icon indicating copy to clipboard operation
cli copied to clipboard

feat: deprecate some access subcommands

Open fritzy opened this issue 3 years ago • 2 comments

Added warning logs for npm access <subcommand> for the following subcommands:

  • 2fa-required
  • 2fa-not-required
  • public
  • restricted
  • edit
  • ls-packages
  • ls-collaborators

fritzy avatar Jul 12 '22 17:07 fritzy

ref: https://github.com/npm/statusboard/issues/486

wraithgar avatar Jul 12 '22 17:07 wraithgar

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.305 ±0.29 17.302 ±0.07 15.401 ±0.27 17.965 ±0.81 2.705 ±0.00 2.684 ±0.04 2.187 ±0.04 10.595 ±0.10 2.148 ±0.01 3.154 ±0.00
#5155 38.039 ±1.40 17.652 ±0.15 15.119 ±0.02 17.912 ±0.98 2.700 ±0.01 2.696 ±0.00 2.163 ±0.00 10.620 ±0.01 2.155 ±0.01 3.219 ±0.05
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 27.983 ±0.83 13.073 ±0.14 11.335 ±0.02 12.000 ±0.18 2.504 ±0.01 2.443 ±0.01 2.235 ±0.02 7.706 ±0.02 2.059 ±0.01 3.171 ±0.42
#5155 27.664 ±1.33 13.492 ±0.71 11.383 ±0.13 12.301 ±0.09 2.468 ±0.01 2.471 ±0.03 2.223 ±0.01 7.688 ±0.07 2.069 ±0.02 2.887 ±0.06

npm-cli-bot avatar Jul 12 '22 17:07 npm-cli-bot

We got our wires crossed and duplicated this effort in https://github.com/npm/cli/pull/5347

wraithgar avatar Sep 08 '22 17:09 wraithgar