kitsune-application-development-kit icon indicating copy to clipboard operation
kitsune-application-development-kit copied to clipboard

Vulnerability : Server-Generated ACAO Header From Client-Specified Origin

Open sgwgsw opened this issue 1 year ago • 0 comments

https://github.com/nowfloats/kitsune-application-development-kit/blob/811be8fcf5bcb7ea627d2eb530d3e7210b40a102/KAdmin/Utils/AllowCorsFilter.cs#L12-L20

This vulnerability affects the admin dashboard.

The client's Origin header is reflected in the Access-Control-Allow-Origin header from the server, granting any domain access to CORS resources behind the admin dashboard. There should be a white-list in the configuration that lists allowed Origin headers.

The issue is made worse with "Access-Control-Allow-Credentials: true". Now that any domain can access the endpoints, they also can also authenticate as another user. This can be done by sending a crafted link to a user who is logged in (presumably, unless session token is persistent) - once clicked, the script would send a CORS request to sensitive endpoints and the browser would send along their cookies since "Access-Control-Allow-Credentials: true" is set.

More info on vulnerability - https://portswigger.net/web-security/cors#server-generated-acao-header-from-client-specified-origin-header

sgwgsw avatar Jan 09 '24 18:01 sgwgsw