novu-ruby icon indicating copy to clipboard operation
novu-ruby copied to clipboard

Bump version of active-support

Open clgiovannelli opened this issue 1 year ago • 10 comments

Hi all, do you think is possible to use activesupport > 6.1.7.2 instead of activesupport = 6.1.7.2?

Thank you in advance

clgiovannelli avatar Nov 09 '23 16:11 clgiovannelli

Any update?

clgiovannelli avatar Dec 13 '23 13:12 clgiovannelli

Any particular reason for this request? @clgiovannelli

unicodeveloper avatar Dec 14 '23 07:12 unicodeveloper

Thank you for getting back to me, actually I can't install the gem with the latest version of Rails.

clgiovannelli avatar Dec 14 '23 10:12 clgiovannelli

Hi there, I'm considering integrating NOVU into our production environment. I was wondering if you have plans to continue maintaining the Ruby gem? Your guidance on this would be greatly appreciated. Thank you!

clgiovannelli avatar Jan 04 '24 11:01 clgiovannelli

Any particular reason for this request? @clgiovannelli

@unicodeveloper The sdk is pegged to version 6.1.7.2 for the activesupport dependency, that was the configuration at the beginning. It would be nice to allow the sdk accept higher version of activesupport dependency for forward compatibility sake.

Eazybright avatar Jan 07 '24 12:01 Eazybright

Any particular reason for this request? @clgiovannelli

@unicodeveloper The sdk is pegged to version 6.1.7.2 for the activesupport dependency, that was the configuration at the beginning. It would be nice to allow the sdk accept higher version of activesupport dependency for forward compatibility sake.

@Eazybright would you like to work on this?

jainpawan21 avatar Jan 16 '24 15:01 jainpawan21

I have tagged a new release. v1.1.0. Please update your gem @clgiovannelli

unicodeveloper avatar Jan 16 '24 18:01 unicodeveloper

Hi @unicodeveloper,

After updating the gem, it appears that it can't find exponential-backoff and uuid. In fact, these dependencies were not defined in the gemspec. I resolved the issue by manually adding the gems to the bundler. However, it would be greatly appreciated if these dependencies could be included in the gemspec.

Thank you in advance.

clgiovannelli avatar Jan 17 '24 14:01 clgiovannelli

@clgiovannelli thanks for pointing this out. A PR has been raised to fix it https://github.com/novuhq/novu-ruby/pull/65

Eazybright avatar Jan 17 '24 19:01 Eazybright

@clgiovannelli thanks for pointing this out. A PR has been raised to fix it #65

It's working, thank you!

clgiovannelli avatar Jan 22 '24 15:01 clgiovannelli