notation icon indicating copy to clipboard operation
notation copied to clipboard

feat: introduce golang ci lint action

Open tungbq opened this issue 2 years ago • 4 comments
trafficstars

Resolves: #718

Background (mentioned in the issue #718 ):

Golang lint is a fast Go linters runner. It runs linters in parallel, uses caching, supports yaml config. It’s used to make sure code adheres to common Go practices. It supports enable many different types of linters.

Changes:

  • Add golangci-lint-action to the CI workflows as it's the official GitHub action for golangci-lint from its authors. The action runs golangci-lint and reports issues from linters.
  • Name the new workflow as golangci-lint in .github/workflows/go-lint.yml
  • Current behaviour:
    • Run golangci-lint on every PR
    • Report only new issue generated from the PR
    • Beside of PR events, there has an option in the trigger event to allow us manually run the workflow if needed (workflow_dispatch:)

Testing:

  • This was tested on my fork repository
  • For example, https://github.com/tungbq/notation/pull/4

tungbq avatar Jun 24 '23 09:06 tungbq

Codecov Report

Merging #723 (79beaf2) into main (0f3c4ae) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   46.59%   46.59%           
=======================================
  Files          40       40           
  Lines        2232     2232           
=======================================
  Hits         1040     1040           
  Misses       1105     1105           
  Partials       87       87           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jun 26 '23 02:06 codecov-commenter

This issue that caused by Zot V2.0.0-rc.5 update will be resolved in https://github.com/notaryproject/notation/pull/727

This PR decreases the code coverage for 17.04%. Could you take a look?

JeyJeyGao avatar Jun 28 '23 02:06 JeyJeyGao

This issue that caused by Zot V2.0.0-rc.5 update will be resolved in #727

This PR decreases the code coverage for 17.04%. Could you take a look?

Thanks for pointing this @JeyJeyGao

tungbq avatar Jun 28 '23 14:06 tungbq

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

github-actions[bot] avatar Mar 22 '24 01:03 github-actions[bot]

PR closed due to no activity in the past 30 days.

github-actions[bot] avatar Apr 21 '24 01:04 github-actions[bot]