nostrability icon indicating copy to clipboard operation
nostrability copied to clipboard

Nests breaks damus follows

Open alltheseas opened this issue 1 year ago • 8 comments

client initiating action

Nests

It all started after following a person on nosternests. Downhill from there.

client receiving or observing action (or lack thereof)

Damus

timestamp

https://damus.io/nevent1qqsyhe2ekdggdthgn45k5j99mgrqrygsv3taxeqmgyaukgcfu7t6xwqzff7rr

image

what happens

Lost followers

suggestion

@v0l

alltheseas avatar Apr 20 '24 21:04 alltheseas

Apps other than Damus reported affected

alltheseas avatar Apr 21 '24 13:04 alltheseas

https://njump.me/note1cr2z8pvmjamuhrj33xsv3eugjd34ywum4dfyu6n7ulk2zfpg6v4slquntn

Behavior in damus

alltheseas avatar Apr 21 '24 14:04 alltheseas

I believe the root cause is Nests has a bug where it puts an encoded npub in the p tag.

Semisol avatar May 08 '24 16:05 Semisol

I believe the root cause is Nests has a bug where it puts an encoded npub in the p tag.

What's the best way to fix? Get to @derekross and @v0l attention?

Can you submit a PR @Semisol ?

alltheseas avatar May 08 '24 17:05 alltheseas

@fiatjaf who is the dev / maintainer of the nostr dot com list restore tools?

The user submitting the feedback here is saying the restore tools do not work in his case.

alltheseas avatar May 09 '24 18:05 alltheseas

the presence of an npub could fail a filter in Damus, which we can fix, but I don't see how the whole list could have been nuked.

jb55 avatar May 09 '24 18:05 jb55

but yeah should definitely add some tests for bad data in lists and see how that affects things. I could have swore we parse that out though when creating the filter...

jb55 avatar May 09 '24 18:05 jb55

Btw, side note that might help with troubleshooting.

I now understand what the blank notes are because I saw it glitch once.

The blank notes are not “missing data”

It’s a rendering issue, all the objectives that should be in the blank note will be render outside, like on top of another note for example, or outside of the view.

From bug reporter

alltheseas avatar May 09 '24 20:05 alltheseas