Erik Nordin

Results 28 comments of Erik Nordin

@selimsum that's great news! Thank you so much for taking a look. Here is an updated version that no longer contains _am'Şirketimin_. Would you say that this is an improvement,...

> This one isn't a made-up word so it's definitely an improvement. > > Considering that it's the same model, I'm not evaluating the overall translation quality but I should...

I just read through this whole thread and I definitely support this new design. This feels much more focused on ICU4X end-user API ergonomics, as it should be. My old...

I vaguely recall having this same issue with the original [build-bergamot.py](https://searchfox.org/mozilla-central/rev/b655023a1978bcad8cc2fb038b89a058b45e91a7/toolkit/components/translations/bergamot-translator/build-bergamot.py#148-173) script, because the part where the git patches are applied happens before calling `cmake`, and `cmake` is the command...

@gregtatum I've pushed up two new commits. Firstly, I fixed the submodule initialization to ensure that the directories exist before applying the patches. I've tested this end-to-end on my macOS...

In the Translations UI code within Firefox we use the [Intl.DisplayNames](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DisplayNames) object, which pulls [CLDR](https://github.com/unicode-org/cldr) data and is supported by all of the major browsers directly within JavaScript. Here is...

Hey @petrosagg Thanks for all the further explanation and discussion! I had misinterpreted your code in an attempt to finish this review quickly before the end of my day. I...

LGTM after reading the comments. I don't think I have anything else to add.