iterm2
iterm2 copied to clipboard
nordtheme
Adjusted comment colors to be brighter.
As per color brightness adjustments in other Nord projects here, comment brightness was increased by 8%. Specifically converted it to the exact measurement of nord-vim done here.
Did notice that iterm2 exports out as sRGB now instead of Calibrated so unfortunately the amounts are all slightly different.
Hi @NathanielInman :wave:, thanks for your contribution :+1: Sorry for the late reply, must have missed this one in my overfilled notification inbox.
Like described in arcticicestudio/nord#94 the change in this PR would conflict with the goal:
Note that this will not affect Nord itself, the color palette won't change.
This project only provides the actual colors of the Nord palettes where nord3 is one of them. The goal was to increase the brightness only for comments in port projects that provide syntax highlighting capabilities. Changing the actual terminal color scheme would override/remove the original nord3 color value.
The only use case where iTerm2 acts as syntax highlighter is when writing shell script comments interactively, but this is a edge case that is not possible to resolve with the current iTerm2 theme API (would require an additional color definition key only for shell script comments).
As you can see in the PR for Nord Vim a new color variable was added while the nord3_gui and nord3_term variables have not been touched. The new variable provides the color value with the brightened comment color and is used for the syntax highlighting groups of the different languages and plugins that are scoped for comment tokens.
I'm currently not sure about the change of the Calibrated to sRGB format because I think I remember that this could be decided by the user to allow to optimize it for different monitor types, but I guess this requires some research in their documentation.
