Joel Holdbrooks

Results 128 comments of Joel Holdbrooks
trafficstars

> The secretary readme describes a google closure history config that discards the query params from the token. @julienfantin I don't recall this being an issue but if it is...

@bago2k4 Sorry for the delay on getting back to you. `locate-route` isn't necessary on the `2.0.0` branch because the creation of routes and how to dispatch to them is pretty...

@hosiawak I don't have to time to put together the source for that but at any rate the README probably wouldn't be the place for it. Also I'm not clear...

You could handle authentication before calling `secretary/dispatch!` on hash changes. > Is there middleware for Secretary? No, not built in, but I think it's something worth considering for future versions....

@jeluard Hmm... I don't think there is anything special about the new API that would apply to that problem specifically. OTOH you could create middleware which would check if the...

@jeluard This might be a better illustration ``` clj (defn wrap-add-login-status [handler] (fn [req] (handler (assoc req :logged-in? (logged-in?))))) (defn wrap-authorized [handler] (fn [req] (if (:logged-in? req) (handler (assoc-in req...

@jeluard If it helps at all have a look at very simple dispatcher [here](https://github.com/gf3/secretary/blob/v2.0.0/test/secretary/test/core.cljs#L107-L130) in the tests.

@stephanos I just need to write the documentation for it and patch one more thing. Other than that it's pretty much ready to go. We're using this branch in production...

@stephanos I should clarify that there are other design differences between Silk and Secretary but in my opinion there isn't a lot of contrast between the two. If you find...

@dgellow It's a bit stale at the moment. :disappointed: