npdynamodb icon indicating copy to clipboard operation
npdynamodb copied to clipboard

Fix MigrateRunner._createMigrateTableIfNotExists

Open sean-krail opened this issue 6 years ago • 2 comments

_createMigrateTableIfNotExists now works when there are more than 100 tables (DynamoDB has a soft limit of 256 tables per region). Say you have 101 tables table1 through table100 and your migration history table's name is table101, the function thinks the migration history table doesn't exist, tries to create it, and then throws a ResourceInUseException since it really does exist.

Changes

  • renamed _createMigrateTableIfNotExits to _createMigrateTableIfNotExists
  • _createMigrateTableIfNotExists now uses describeTable instead of listTables to figure out if the migration history table already exists. This change was made since listTables uses pagination which defaults to 100 and describeTable can fetch one table by name.

sean-krail avatar Dec 04 '19 22:12 sean-krail

@noppoMan the travis tests are broken for node v4 and v5, all other versions are working as expected.

sean-krail avatar Dec 04 '19 22:12 sean-krail

@noppoMan https://github.com/noppoMan/npdynamodb/pull/73 fixes the travis tests

sean-krail avatar Dec 04 '19 22:12 sean-krail