nparse icon indicating copy to clipboard operation
nparse copied to clipboard

Read spells_us.txt from game directory

Open That-one-Joe opened this issue 2 years ago • 1 comments

Reading the spells_us.txt from the game directory would mean that the correct timings would be used automatically. I do not see any advantage of this file being in this project; it can possibly only use wrong timings which led me to create this issue - but maybe I am missing something why it was done this way.

https://github.com/nomns/nparse/blob/master/parsers/spells.py#L478 is the location for the change.

I propose changing eq_log_dir in the config to eq_dir generally, automatically appending Logs for the log reading and using this in spells.py for reading spells_us.txt.

That-one-Joe avatar Dec 09 '22 22:12 That-one-Joe

There are a lot of custom changes that have been made to that file to actually make things work correctly in-era and with certain features. It would just exhibit many other issues if this were done. Out of curiosity, are you on P99, TLP, or some other server? @That-one-Joe

rm-you avatar Apr 15 '24 17:04 rm-you