Simon Vergauwen

Results 206 comments of Simon Vergauwen
trafficstars

I converted this PR back to a DRAFT to prevent it from getting merged. I am currently still writing docs, and tests and investigating `EagerEffect`. I've also updated the APIs...

@serras thanks for that comment. I need to look into it. I tried to solve the problem on branch `effect-as-value-class`, but it seems to make things much worse 😅 The...

@serras oops. force of habit. There was conflict between `arrow-2` and this one, and I accidentally merged the wrong one. Thanks for spotting it!

I think this PR is ready for re-review @i-walker @raulraja @serras. I explored the changes for `EagerEffect` as well. # New Changes - We used `Token` to identify the `Scope`,...

If this is approved by everyone, I’ll backport the changes to 1.x were applicable.

> Are you closing this PR and making a new one against a (rebased) arrow-2 branch, or merging with this? Whatever makes most sense for you, and the other reviewers....

I am going to close this PR in favour of #2797. We can re-open this PR if needed.

Sounds great! We should probably do same for all other zip functions.

> My suggestion is to not inline those termination points. We should still `inline` to allow suspension, so we need concrete implementations for all of them. Right?

Hey @Kernald, Currently our biggest blocker for publish `BOTH` is that we cannot run tests for the legacy JS target. I am personally not using Kotlin JS a lot, but...