gpt4all icon indicating copy to clipboard operation
gpt4all copied to clipboard

Make the stop generation button visible during model response.

Open manyoso opened this issue 1 year ago • 4 comments

This ensures that it is always clear when the response is still being generated and it also makes it easier to stop generation. Seems like a decent solution?


:rocket: This description was created by Ellipsis for commit 4fdab841788160d72aadf56699292a88773694dd

Summary:

Moved the stop generation button to a more prominent location and ensured its visibility during response generation in gpt4all-chat/qml/ChatView.qml, with theme property updates in gpt4all-chat/qml/Theme.qml.

Key points:

  • Modified gpt4all-chat/qml/ChatView.qml to move the stopButton outside the conversation tray and make it always visible during response generation.
  • Updated stopButton visibility conditions to currentChat.responseInProgress && !currentChat.isServer.
  • Renamed theme properties in gpt4all-chat/qml/Theme.qml:
    • sendButtonBackground to conversationInputButtonBackground
    • sendButtonBackgroundHovered to conversationInputButtonBackgroundHovered.
  • Ensured stopButton is more accessible and easier to use during response generation.

Generated with :heart: by ellipsis.dev

manyoso avatar Jul 04 '24 23:07 manyoso