nodemcu-firmware icon indicating copy to clipboard operation
nodemcu-firmware copied to clipboard

Next release snap

Open marcelstoer opened this issue 1 year ago • 6 comments

This was triggered by Gregor's comment at https://github.com/nodemcu/nodemcu-firmware/pull/3633#issuecomment-1930439746.

It's been ages since we last snapped something back to the release branch. What we documented at https://github.com/nodemcu/nodemcu-firmware/blob/release/CONTRIBUTING.md#handling-releases is mostly still correct 😄

marcelstoer avatar Feb 06 '24 21:02 marcelstoer

Would like to add 1 or 2 pull reques first.

HHHartmann avatar Feb 07 '24 03:02 HHHartmann

@HHHartmann which ones did you have in mind?

marcelstoer avatar Feb 13 '24 16:02 marcelstoer

I would suggest these at least:

  • [x] #3637
  • [x] #3632
  • [x] #3633

and maybe this one, but it would need a little bit of love first

  • [x] #3450

And of course I'd still like to get this integrated:

  • [x] #3230

HHHartmann avatar Feb 18 '24 09:02 HHHartmann

The first four seemed like no-brainers. Hence, I felt confident to merge them 😄

As for the last one, I'm completely lost, not my world.

marcelstoer avatar Feb 18 '24 10:02 marcelstoer

When merging this PR a github workflow should start creating the release note together with attached luac.cross binaries for windows. So give it some time. Trigger is:

on:
  push:
    tags:
      - '3.*-release_*'

HHHartmann avatar Feb 18 '24 11:02 HHHartmann

found some more changes that hepled me:

  • [x] #3638

HHHartmann avatar Feb 18 '24 16:02 HHHartmann