nodemcu-firmware icon indicating copy to clipboard operation
nodemcu-firmware copied to clipboard

espconn lwip wrappers actively harmful

Open nwf opened this issue 5 years ago • 4 comments
trafficstars

As far as I can tell, anyway, these things are just obstruction, rather than abstraction, over lwip. See, for example, the damage they cause with #2987: it is neither obvious nor documented that espconn_gethostbyname passes the espconn structure as the callback argument. We should just be calling dns_gethostbyname ourselves and passing the appropriate lua object to the callback.

Am I missing something and espconn is actually useful? If not, I think I will propose that we attempt to excise it from our tree.

nwf avatar Jan 05 '20 01:01 nwf

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 31 '21 01:01 stale[bot]

Still true, sadly.

nwf avatar Jan 31 '21 02:01 nwf

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 07:04 stale[bot]

Is it still true?

HHHartmann avatar Apr 19 '22 04:04 HHHartmann