nodejs.org
nodejs.org copied to clipboard
fix: Change link to point to npm release notes
Description
Previously, this link was pointing to the npm registry which looks nearly the same for every release.
This PR changes the link to point to the release notes for the given version of npm.
Validation
Click on "Node.js includes npm (10.2.4)" here:
Related Issues
None
Check List
- [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
- [ ] I have run
npx turbo formatto ensure the code follows the style guide. - [ ] I have run
npx turbo testto check if all tests are passing. - [ ] I have run
npx turbo buildto check if the website builds without errors. - [ ] I've covered new added functionality with unit tests if necessary.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| nodejs-org | ✅ Ready (Inspect) | Visit Preview | Mar 24, 2024 0:17am |
@ovflowd it was you who put this link up, any reason?
I'm fine with the GitHub release too.
Can you double check, @styfle that this link works for every version from our Dropdown selector?
@ovflowd I confirmed that all links work 👍
However, a few old releases don't have notes (its just the tag) such as https://github.com/npm/cli/releases/tag/v2.15.11
I think that is an acceptable trade off.
Lighthouse Results
| URL | Performance | Accessibility | Best Practices | SEO | Report |
|---|---|---|---|---|---|
| /en | 🟢 96 | 🟢 90 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about | 🟢 100 | 🟢 91 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about/previous-releases | 🟢 98 | 🟢 90 | 🟢 100 | 🟢 92 | 🔗 |
| /en/download | 🟢 100 | 🟠 89 | 🟢 100 | 🟢 91 | 🔗 |
| /en/blog | 🟢 99 | 🟢 90 | 🟢 100 | 🟢 92 | 🔗 |
Unit Test Coverage Report
| Lines | Statements | Branches | Functions |
|---|---|---|---|
| 80.07% (450/562) | 79.55% (144/181) | 71.17% (79/111) |
Unit Test Report
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 90 | 0 :zzz: | 0 :x: | 0 :fire: | 4.377s :stopwatch: |
@styfle could you run prettier locally? Apparently it is not happy