node
node copied to clipboard
tty: improve color terminal color detection
This adds a couple new entries or increases the support depending on newer data. I checked ncurses, tput, supports-color, and termstandard on github. Most updates are from supports-color.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.17%. Comparing base (
f89baf2) to head (143b05d). Report is 312 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #58146 +/- ##
==========================================
- Coverage 90.24% 90.17% -0.08%
==========================================
Files 630 630
Lines 185670 186496 +826
Branches 36401 36614 +213
==========================================
+ Hits 167567 168174 +607
- Misses 10992 11130 +138
- Partials 7111 7192 +81
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/internal/tty.js | 99.23% <100.00%> (+2.18%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Failed to start CI
⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14824758970
@nodejs/tty PTAL
CI: https://ci.nodejs.org/job/node-test-pull-request/66706/
CI: https://ci.nodejs.org/job/node-test-pull-request/66897/
CI: https://ci.nodejs.org/job/node-test-pull-request/66962/
Commit Queue failed
- Loading data for nodejs/node/pull/58146 ✔ Done loading data for nodejs/node/pull/58146 ----------------------------------- PR info ------------------------------------ Title tty: improve color terminal color detection (#58146) Author Ruben Bridgewater <[email protected]> (@BridgeAR) Branch BridgeAR:improve-color-support-detection -> nodejs:main Labels tty, author ready, needs-ci Commits 1 - tty: improve color terminal color detection Committers 1 - Ruben Bridgewater <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58146 Refs: https://github.com/nodejs/node/issues/57998 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58146 Refs: https://github.com/nodejs/node/issues/57998 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 03 May 2025 18:47:06 GMT ✔ Approvals: 2 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/58146#pullrequestreview-2824049258 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58146#pullrequestreview-2831773381 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-05-20T10:08:40Z: https://ci.nodejs.org/job/node-test-pull-request/66962/ - Querying data for job/node-test-pull-request/66962/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15147622357
CI: https://ci.nodejs.org/job/node-test-pull-request/66970/
Landed in 0e72f3b7155a04227b5fa301bdc22863a76194f3