node icon indicating copy to clipboard operation
node copied to clipboard

test: skip test-buffer-tostring-rangeerror when low on memory

Open BridgeAR opened this issue 7 months ago • 4 comments

This has shown up as RangeError: Array buffer allocation failed and it should be totally fine to skip this test in case the memory is low.

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/33969/RUN_SUBSET=2,nodes=win2019-COMPILED_BY-vs2019/console

13:36:31 not ok 105 parallel/test-buffer-tostring-rangeerror
13:36:31   ---
13:36:31   duration_ms: 263.03700
13:36:31   severity: fail
13:36:31   exitcode: 1
13:36:31   stack: |-
13:36:31     node:assert:377
13:36:31           throw err;
13:36:31           ^
13:36:31     
13:36:31     AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
13:36:31     + actual - expected
13:36:31     
13:36:31       Comparison {
13:36:31     +   name: 'RangeError'
13:36:31     -   code: 'ERR_STRING_TOO_LONG',
13:36:31     -   name: 'Error'
13:36:31       }
13:36:31         at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-buffer-tostring-rangeerror.js:21:8)
13:36:31         at Module._compile (node:internal/modules/cjs/loader:1529:14)
13:36:31         at Module._extensions..js (node:internal/modules/cjs/loader:1613:10)
13:36:31         at Module.load (node:internal/modules/cjs/loader:1275:32)
13:36:31         at Module._load (node:internal/modules/cjs/loader:1096:12)
13:36:31         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:164:12)
13:36:31         at node:internal/main/run_main_module:28:49 {
13:36:31       generatedMessage: true,
13:36:31       code: 'ERR_ASSERTION',
13:36:31       actual: RangeError: Array buffer allocation failed
13:36:31           at new ArrayBuffer (<anonymous>)
13:36:31           at new Uint8Array (<anonymous>)
13:36:31           at new FastBuffer (node:internal/buffer:961:5)
13:36:31           at Function.alloc (node:buffer:397:10)
13:36:31           at Buffer (node:buffer:275:19)
13:36:31           at C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-buffer-tostring-rangeerror.js:21:21
13:36:31           at getActual (node:assert:498:5)
13:36:31           at Function.throws (node:assert:644:24)
13:36:31           at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-buffer-tostring-rangeerror.js:21:8)
13:36:31           at Module._compile (node:internal/modules/cjs/loader:1529:14),
13:36:31       expected: { code: 'ERR_STRING_TOO_LONG', name: 'Error' },
13:36:31       operator: 'throws'
13:36:31     }
13:36:31     
13:36:31     Node.js v20.19.2-pre
13:36:31   ...

BridgeAR avatar May 03 '25 16:05 BridgeAR

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14813004228

github-actions[bot] avatar May 03 '25 17:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.17%. Comparing base (f89baf2) to head (6f18c3c). Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58142      +/-   ##
==========================================
- Coverage   90.24%   90.17%   -0.08%     
==========================================
  Files         630      630              
  Lines      185670   186473     +803     
  Branches    36401    36609     +208     
==========================================
+ Hits       167567   168154     +587     
- Misses      10992    11119     +127     
- Partials     7111     7200      +89     

see 108 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 03 '25 17:05 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66579/

nodejs-github-bot avatar May 04 '25 08:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66589/

nodejs-github-bot avatar May 04 '25 17:05 nodejs-github-bot

Landed in 5f252a45bc4db17b1ba41a747a2dc1a63ed7dbae

nodejs-github-bot avatar May 07 '25 16:05 nodejs-github-bot