node
node copied to clipboard
nodejs
deps: cherry-pick 88260bf from node-gyp upstream
This change cherry-picks a small change from node-gyp needed for running native tests on ClangCL compiled binaries. The change was already approved here, so this is just the official port after the changes landed in node-gyp. Next is the part of the description regarding this change from the original PR:
Enforce MSVC to be used for node-gyp. As far as I can tell, this is the intended way of using node-gyp on Windows. The issue with running the native suites is that now we use Clang to compile Node.js, so config.variables.clang is set to 1, which makes node-gyp generate project files for ClangCL. While we'd like to enable this, that is currently not the priority so for now enforcing MSVC would be the way to go the way I see it. The changes in create-config-gypi.js would be done as a PR in node-gyp and then floated in Node.js until the next node-gyp update.
Tagging relative teams: @nodejs/platform-windows @nodejs/node-gyp
P.S. Since it's already reviewed, I'll request fast-tracking and I'm planning to land it after the first approval.
Refs: https://github.com/nodejs/node-gyp/pull/3098 Refs: https://github.com/nodejs/node/pull/55784
Fast-track has been requested by @StefanStojanovic. Please 👍 to approve.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Since this is located in the deps/npm, my second think is that this cherry pick would make the npm bundled with nodejs diverged from the one released on npm. I think this might not be a good idea and better to wait npm upgrades. /cc @nodejs/npm
I think this might not be a good idea and better to wait npm upgrades.
Correct. It looks like 10.3.0 was not published yet. Once it is npm can update.
Yes, just noticed that the publish workflow was not working. Fixing at https://github.com/nodejs/node-gyp/pull/3099
Since this is located in the
deps/npm, my second think is that this cherry pick would make the npm bundled with nodejs diverged from the one released on npm. I think this might not be a good idea and better to wait npm upgrades. /cc @nodejs/npm
I understand the concern and it is completely valid. Any idea on the ETA of node-gyp v10.3,0 making its way into the Node.js project (so full journey, node-gyp release, npm update, npm release, and node update)?
Regarding the change itself, although it is not a good practice to get it this way, it would not break anything, as using Clang is AFAIK not supported on Windows anyway, so IMHO this is not risky (although it is a dirty solution).
Knowing an ETA on this would be helpful.
Any idea on the ETA of node-gyp v10.3,0 making its way into the Node.js project (so full journey, node-gyp release, npm update, npm release, and node update)?
I can't speak to the full timeline but do want to point out that #56135 has landed which contains the change from this PR. So the only step remaining is the node update which I think means this PR can be closed now.
