node icon indicating copy to clipboard operation
node copied to clipboard

Please add latest brotli 1.1.0 bindings with compression dictionary support

Open nhelfman opened this issue 1 year ago • 3 comments
trafficstars

What is the problem this feature will solve?

Current node brotli compression does not support compression dictionary. The dictionary option only supported for deflate/inflate according to documentation:

dictionary <Buffer> | <TypedArray> | <DataView> | <ArrayBuffer> (deflate/inflate only, empty dictionary by default)

This prevents using node.js directly to create compression dictionary diffs at build time which is necessary in order to adopt Compression dictionary transport

What is the feature you are proposing to solve the problem?

Add latest code/binaries and binding to compression options to support latest brotli (https://github.com/google/brotli) version 1.1.0 so that we can use the dictionary option in brotli.

cc: @benjamingr

What alternatives have you considered?

No response

nhelfman avatar Mar 28 '24 13:03 nhelfman

@nodejs/zlib it looks like this just needs exposing in the API JS side

benjamingr avatar Apr 01 '24 04:04 benjamingr

I can work on this :-)

juanarbol avatar Apr 02 '24 19:04 juanarbol

@juanarbol is this in flight somewhere, would love to poke at a dev branch or something 🤔 Poking at the compression dictionary transport tech and built in bindings would make this a lot easier 😅

Happy to help out with the change too 🥳

MarshallOfSound avatar Jun 26 '24 07:06 MarshallOfSound

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the https://github.com/nodejs/node/labels/never-stale label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment. For more information on how the project manages feature requests, please consult the feature request management document.

github-actions[bot] avatar Dec 24 '24 01:12 github-actions[bot]

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

github-actions[bot] avatar Jan 24 '25 01:01 github-actions[bot]

@juanarbol / @avivkeller is there any update on this elsewhere? Seems like this was planned

alex-statsig avatar Feb 04 '25 19:02 alex-statsig