node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard

The `VCCLCompilerTool.floatingPointModel` setting is not recognized.

Open issuefiler opened this issue 2 years ago • 0 comments
trafficstars

Environment

Version

node-gyp 9.3.0

binding.gyp

"msvs_settings": {
	"VCCLCompilerTool": {
		"floatingPointModel": 2, # /fp:fast
	}
}

Output

Warning: unrecognized setting VCCLCompilerTool/floatingPointModel while converting to MSBuild.

Bug

MSVSSettings.ValidateMSVSSettings does not recognize the VCCLCompilerTool.floatingPointModel setting and tries to validate VCCLCompilerTool.FloatingPointModel, when in fact, there’s no such thing as VCCLCompilerTool.FloatingPointModel but VCCLCompilerTool.floatingPointModel.

I know, of all properties of VCCLCompilerTool that start with a capital letter, this oddly starts with a lowercase letter. But look; it is:

VCCLCompilerTool.floatingPointModel Property

Sets or gets the floating point model.

issuefiler avatar Dec 10 '22 10:12 issuefiler