node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

Update workflow to check for conventional commit types

Open anonrig opened this issue 3 years ago • 2 comments

I recommend updating the pull request workflow to check for conventional commit format in the commits, since release changelog requires it.

If there's no objections, I'll be happy to add it.

https://www.conventionalcommits.org/en/v1.0.0/

anonrig avatar Dec 06 '22 18:12 anonrig

There's already https://github.com/nodejs/node-core-utils/blob/main/.github/workflows/commitlint.yml, what else do you have in mind?

aduh95 avatar Dec 06 '22 19:12 aduh95

I need we need to also check the title of the pull request for conventional commit format in order to reduce the probability of failures on squashed pull requests with names.

anonrig avatar Dec 06 '22 19:12 anonrig