node-addon-api

node-addon-api copied to clipboard

Build problem using VS2019 when upgrading addon from 1.7.2 to 4.3.0

2

I'm upgrading an addon I developed in VS2019 from node-addon-api version 1.7.2 to 4.3.0. When I build I get the error "'_mutex': unknown override specifier" and "missing type specifier -...

lxanderm

Segfault on shutdown with ObjectWrap

5

I am seeing a segfault with the [email protected] when the node processes tears down, and it appears related to the cleanup of a an ObjectWrap instance that is explicitly referenced,...

Matt-Esch

Boilerplate-less way to write node-addon-api code

2

I've implemented https://github.com/ajihyf/node-addon-api-helper which may help to write boilerplate-less node-addon-api code. There is another issue https://github.com/nodejs/node-addon-api/issues/294 but not active for a while. Though WebIDL isn't supported currently, the approach is...

ajihyf

src: fix -Wconversion msg/C++17 UB from unknown_array_type

2

Opening gambit to fix #1066. Only lightly tested (I'll fix the errors, no need to comment on those). Seeking feedback on the approach before adding tests. Breaking change: this makes...

zbjornson

Migration from NAN to object_wrap / determine invoked property name

15

This is a usage / migration from NAN question. With NAN I used the following to determine the invoked property name: ``` NAN_GETTER(ClassName::Getters) { ... std::string propertyName = *Nan::Utf8String(property); ......

pdehne

`const` error with `AsyncProgressWorker<T>::ExecutionProgress::Signal()`

9

Hi 👋 I'm getting the following error trying to call `.Signal()` on `AsyncProgressWorker::ExecutionProgress`: View error ``` In file included from /home/jpaye/nuclearnet.js/node_modules/node-addon-api/napi.h:2905, from ../src/NetworkBinding.hpp:22, from ../src/NetworkListener.hpp:21, from ../src/NetworkListener.cpp:18: /home/jpaye/nuclearnet.js/node_modules/node-addon-api/napi-inl.h: In instantiation...

JosephusPaye

(Typed)ThreadSafeFunction.Release() crashes renderer process on reload (& abort?)

15

We are using a native addon with Electron (Both v14 and v16 show the same behaviour) There is a class, which roughly looks like this: ``` class Foo : public...

robinchrist

AsyncProgress*Worker does not support compile option -Woverloaded-virtual

3

Due to Execute() method overloaded in AsyncProgressWorker and AsyncProgressQueueWorker, projects using these classes and with `-Woverloaded-virtual` enabled will fail to compile. **Reproduction** Apply the following and run tests. ``` diff...

jerylvaz

`ThreadSafeFunction` should handle exceptions in async callbacks identical to Node itself

14

This is a duplicate of #669 When a JS callback called from a `ThreadSafeFunction` throws an exception, the result is: ``` terminate called after throwing an instance of 'Napi::Error' what():...

mmomtchev

Update CHANGELOG.md

1

Corrected some misspelled words. a

saintgabriel0