node-addon-api icon indicating copy to clipboard operation
node-addon-api copied to clipboard

[Test] Unit test coverage for CallbackInfo

Open JckXia opened this issue 4 years ago • 2 comments

class methods
CallbackInfo
Covered indirectly via call to Function::New CallbackInfo(napi_env env, napi_callback_info info)
Covered indreictly via call to create array buffers, etc Napi::Env Env() const
Covered Value NewTarget() const
Covered (see function.cc) bool IsConstructCall() const
Covered, function used by many tests size_t Length() const
Covered, function used by various tests const Value operator[] (size_t index) const
Covered, (see addon_data.cc) Value This() const
Covered, see function.cc void * Data() const
void SetData(void * Data)

Just wondering if it's worth writing seperate unit tests for this class?

JckXia avatar Aug 22 '21 16:08 JckXia

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Dec 25 '21 00:12 github-actions[bot]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Apr 15 '22 00:04 github-actions[bot]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Nov 11 '22 00:11 github-actions[bot]

Completed following https://github.com/nodejs/node-addon-api/pull/1253

JckXia avatar Jan 03 '23 21:01 JckXia