http-parser icon indicating copy to clipboard operation
http-parser copied to clipboard

Group related tests into files

Open maclover7 opened this issue 8 years ago • 3 comments

test.c is over four thousand lines long and is getting a little hard to parse... any objections to moving some related tests into separate files in a test/ directory?

@indutny @bnoordhuis

maclover7 avatar Nov 30 '17 03:11 maclover7

Personally, I'm -0.5. Long files don't really bother me and breakups are annoying with git blame. I also don't really enjoy reviewing huge diffs.

But it Fedor thinks it's a good idea, I won't block it.

bnoordhuis avatar Nov 30 '17 09:11 bnoordhuis

ping @indutny

maclover7 avatar Dec 20 '17 15:12 maclover7

+1 for this, sorry for delay. This may require writing a mini test framework, though.

indutny avatar Jan 09 '18 14:01 indutny