http-parser icon indicating copy to clipboard operation
http-parser copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

Making it easier to build it for OpenIndiana

Open rtvd opened this issue 9 years ago • 1 comments

Hello,

I tried packaging this library for OpenIndiana. Would it be possible for you to have the following changes to the Makefile?

  1. Change LIBDIR = $(PREFIX)/lib to LIBDIR ?= $(PREFIX)/lib so that LIBDIR could be re-defined externally.
  2. Change both lines ln -s $(LIBDIR)/$(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT) to ln -s $(SONAME) $(LIBDIR)/libhttp_parser.$(SOEXT) so that relative paths are used for symbolic links.

Thank you.

rtvd avatar May 18 '16 22:05 rtvd

LIBDIR and INCLUDEDIR are overridable w/o any change: make LIBDIR=foo INCLUDEDIR=bar. = gives precedence to make's operands, ?= gives precedence to operands and environment.

i support the second point.

roman-neuhauser avatar Jan 01 '17 22:01 roman-neuhauser