github-bot icon indicating copy to clipboard operation
github-bot copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

Odd `meta` label behavior

Open Fishrock123 opened this issue 9 years ago • 12 comments

in https://github.com/nodejs/node/pull/8466 the bot somehow is adding meta a second time...

Fishrock123 avatar Sep 09 '16 14:09 Fishrock123

AFAIK I don't think it's a bug in github-bot, but a Github UI bug? The labels were all added at the same time it looks like, so maybe a race condition issue on Github's end?

mscdex avatar Sep 09 '16 16:09 mscdex

As the bot fetches the existing labels on a PR via the github API, before adding new ones which haven't already been added, I'm also leaning towards some kind of race condition here..

Have we seen this in other PRs?

phillipj avatar Sep 12 '16 19:09 phillipj

So, we add some $time? We don't have to be 0sec.

jbergstroem avatar Sep 12 '16 23:09 jbergstroem

Either way, maybe github support should be notified about this?

Also AFAIK checking labels first shouldn't even be necessary since github only adds the complement of the intersection of the old label set and the new label set (it does not remove existing labels).

mscdex avatar Sep 12 '16 23:09 mscdex

@mscdex you want to do the honors?

jbergstroem avatar Sep 13 '16 00:09 jbergstroem

@jbergstroem I can try, but I don't have any contacts at Github.

mscdex avatar Sep 13 '16 02:09 mscdex

As the bot fetches the existing labels on a PR via the github API, before adding new ones which haven't already been added ...

I stand corrected -- just realised we don't check existing labels anymore, as of last week w/https://github.com/nodejs/github-bot/commit/4b6f2b3de8c7f290e01917a8e1e283af827a6d89. The newest version of node-github got a new API letting us add labels which POSTs to api.github.com/repos/nodejs/node/issues/X/labels

phillipj avatar Sep 13 '16 07:09 phillipj

@mscdex I've had pretty good success with their public support (https://github.com/contact) -- just ref this issue.

jbergstroem avatar Sep 13 '16 12:09 jbergstroem

@mscdex keep us updated. I've see this on several PRs lately, and if GH is too busy to have a look at this, it's trivial for us revert and only add labels which haven't already been added.

phillipj avatar Sep 16 '16 20:09 phillipj

Just got a response from Github, they've now opened an issue internally to investigate this further. They can't promise an ETA but will keep me updated.

mscdex avatar Sep 19 '16 14:09 mscdex

FYI I've just contacted GitHub support about this again.

phillipj avatar May 06 '17 20:05 phillipj

Still no progress on this internally at GitHub, and no estimate on when it will be prioritised.

In other words, we'll have to get a work around in place to avoid this happening in the near future.

phillipj avatar May 14 '17 20:05 phillipj