github-bot icon indicating copy to clipboard operation
github-bot copied to clipboard

Bot comments three times on V8 CI

Open targos opened this issue 3 years ago • 4 comments

Example: https://github.com/nodejs/node/pull/45162#issuecomment-1290357165

Can we make it comment on the top-level job instead of the three subjobs?

targos avatar Oct 25 '22 11:10 targos

/cc @gengjiawen

targos avatar Oct 25 '22 11:10 targos

This is introduced in https://github.com/nodejs/github-bot/pull/353, not sure the best way to fix it.

gengjiawen avatar Oct 25 '22 12:10 gengjiawen

It seems the bot only got three events for each of the subjobs, so there isn't an event for the parent job. Either we reconfigure Jenkins so that it triggers subjobs as real subjobs (instead of the same job but with different configuration?), or the bot needs to know how to merge the CI links.

joyeecheung avatar Oct 25 '22 14:10 joyeecheung

Either we reconfigure Jenkins so that it triggers subjobs as real subjobs (instead of the same job but with different configuration?)

I am for this one, as long as we can keep the same url and config. Context: https://github.com/nodejs/node-core-utils/commit/046bc0dbea44dafdb42f92bc1006d7cdd7a5f286.

gengjiawen avatar Oct 25 '22 15:10 gengjiawen