github-bot icon indicating copy to clipboard operation
github-bot copied to clipboard

Access for Richard Lau

Open Trott opened this issue 3 years ago • 3 comments

Richard Lau (@richardlau) does not apparently have access to the relevant secrets for the GitHub bot. Let's add him, please?

@nodejs/github-bot @nodejs/build

Trott avatar Aug 24 '22 19:08 Trott

I've had previous private discussions with @mhdawson (I think around the time we were renaming the branches from master->main) and we thought that probably everyone in @nodejs/build-infra probably ought to have access to all the secrets (including the github-bot) in the secrets repo.

richardlau avatar Aug 24 '22 19:08 richardlau

Sounds good to me 👍🏻

The list of people having access to those secrets would benefit from being revisited, that goes for the @nodejs/github-bot team too.

phillipj avatar Aug 25 '22 11:08 phillipj

The list of people having access to those secrets would benefit from being revisited, that goes for the @nodejs/github-bot team too.

I've gone ahead and removed maclover7 and williamkapke as they have both been absent from the core project for years, as far as I know. If there are others to be removed, let me know here or (if you prefer) privately. (My email is in my GitHub profile.)

If Richard wants to add himself to the team, he is an org owner and can do it himself, so I'll leave that alone either way.

Trott avatar Aug 25 '22 17:08 Trott

From build WG meeting: @rvagg has access and will add the access for Richard

sxa avatar Feb 08 '23 23:02 sxa

Now sorted 🎉.

richardlau avatar Feb 08 '23 23:02 richardlau