scripts/attempt-backport.js `inProgress` is always false

[Trott]

inProgress is set to false and then never changed. Should it be removed or is there a bug where somewhere it should be set to true but it's not?

[phillipj]

Very good catch!

Ensuring there's only one backport operation running at once, surely sounds like a good idea to me.

I also notice that script needs some love related to logging, primarily replacing debug with JSON logs via bunyan (read: options.logger) so that we can get a hold of those logs from anywhere / anytime.

@Trott just to confirm; is this functionality still valuable? I haven't been involved in core for a while, but I do remember disabling the dont-land-on-* labels in https://github.com/nodejs/github-bot/commit/acd5bc1062ff9a6ea561b58b4bd61afd6680b9f0#diff-eea09a4f0f8288ff9bd49ef44625f0c1. Should we keep it (and improve it) or delete the whole script?

[Trott]

@Trott just to confirm; is this functionality still valuable? I haven't been involved in core for a while, but I do remember disabling the dont-land-on-* labels in https://github.com/nodejs/github-bot/commit/acd5bc1062ff9a6ea561b58b4bd61afd6680b9f0#diff-eea09a4f0f8288ff9bd49ef44625f0c1. Should we keep it (and improve it) or delete the whole script?

I actually have no idea. Is that a question for @nodejs/build or @nodejs/releasers or someone else? /ping @nodejs/github-bot while I'm at it I guess.