github-bot icon indicating copy to clipboard operation
github-bot copied to clipboard
verified publisher icon nodejs

lts-watch-* labels should not be applied when dont-land-on-* exist

Open mscdex opened this issue 8 years ago • 4 comments

As the title says, if for example a PR has the 'dont-land-on-v6.x' label already, then the bot should not try to add an 'lts-watch-v6.x' label.

mscdex avatar Dec 29 '16 02:12 mscdex

@mscdex do you have an example of this happening? I think in most cases it will not land cleanly then.

Fishrock123 avatar Jan 04 '17 20:01 Fishrock123

@Fishrock123 Example: https://github.com/nodejs/node/pull/10445

node v6.x and older do not have a fast function.bind(), so that PR should not be backported.

mscdex avatar Jan 04 '17 21:01 mscdex

Bump, happened in https://github.com/nodejs/node/pull/10839#event-931668098

image

gibfahn avatar Jan 29 '17 23:01 gibfahn

@gibfahn It might be a good idea to merge these discussions on backport-related issues into the newly created issue here: https://github.com/nodejs/github-bot/issues/120 so that we can compile a list of issues.

mscdex avatar Jan 29 '17 23:01 mscdex