docker-node icon indicating copy to clipboard operation
docker-node copied to clipboard

Commit message convention

Open PeterDaveHello opened this issue 7 years ago • 3 comments

Can we follow https://chris.beams.io/posts/git-commit/ to unify the commit message style?

It'll be good to follow a styling guide, just like coding style.

cc @nodejs/docker

PeterDaveHello avatar Jun 27 '18 11:06 PeterDaveHello

What about something like https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines?

SimenB avatar Jun 27 '18 12:06 SimenB

Not sure if the angular.js style would be too strict? I prefer try to follow the simple 7 rules, but still open to have a try with angular style if it's voted by more members.

PeterDaveHello avatar Jun 27 '18 12:06 PeterDaveHello

It is more strict and possible to verify on CI (commitlint etc). The more convention based approach in your linked post is harder to enforce. Might not be wanted, though 🙂

SimenB avatar Jun 27 '18 13:06 SimenB