citgm icon indicating copy to clipboard operation
citgm copied to clipboard

lookup: add openid-client

Open panva opened this issue 1 year ago • 4 comments

adds openid-client

It covers the Web Cryptography API and Fetch API modules.

panva avatar Oct 15 '24 22:10 panva

Hard Requirements

  • [x] Module source code must be on Github.
  • [x] Published versions must include a tag on Github
  • [x] The test process must be executable with only commands
  • [x] The tests pass on supported major release lines (skipped <20 due to lack of webcrypto global)
  • [x] The maintainers of the module remain responsive when there are problems
  • [x] At least one module maintainer must be added to the lookup maintainers field

Soft Requirements

  • [x] The module must be actively used by the community
  • [x] The module must be heavily depended on
  • [x] The module must cover unique portions of our API (WebCryptoAPI, fetch API)
  • [ ] ❓ The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
  • [ ] The module is under the Node.js foundation Github org
  • [ ] The module is identified as an important module by a Node.js Working Group Procedure

panva avatar Oct 15 '24 22:10 panva

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.76%. Comparing base (92761dd) to head (e50ffb9). Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          29       29           
  Lines        2197     2197           
=======================================
  Hits         2038     2038           
  Misses        159      159           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 15 '24 22:10 codecov-commenter

Let's see how this fares in the CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/259/ Subbuilds:

  • v18.x: https://ci.nodejs.org/job/citgm-smoker-nobuild/1653/
  • v20.x: https://ci.nodejs.org/job/citgm-smoker-nobuild/1654/
  • v22.x: https://ci.nodejs.org/job/citgm-smoker-nobuild/1655/

richardlau avatar Oct 16 '24 13:10 richardlau

hmm, i suspect chrome is not installed on the machines, the end2end tests use puppeteer-core (to orchestrate user interactions) and chrome-launcher to find the chrome executable... So we might not be able to add this to CITGM afterall

panva avatar Oct 16 '24 14:10 panva

I'm refactoring the test suite to be able to execute without puppeteer and a browser driving the interactions.

panva avatar Jun 21 '25 08:06 panva

CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/278/

Subbuilds:

  • v20: https://ci.nodejs.org/job/citgm-smoker-nobuild/1731/
  • v22: https://ci.nodejs.org/job/citgm-smoker-nobuild/1732/
  • v24: https://ci.nodejs.org/job/citgm-smoker-nobuild/1733/

panva avatar Jun 21 '25 10:06 panva

CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/279/ 🟢

Subbuilds:

  • v20: https://ci.nodejs.org/job/citgm-smoker-nobuild/1734/
  • v22: https://ci.nodejs.org/job/citgm-smoker-nobuild/1735/
  • v24: https://ci.nodejs.org/job/citgm-smoker-nobuild/1736/

panva avatar Jun 21 '25 10:06 panva