build icon indicating copy to clipboard operation
build copied to clipboard

Don't build/serve website from NGINX

Open MattIPv4 opened this issue 1 year ago • 4 comments

The website is now served from Vercel, so it is redundant to serve it from NGINX as well. It has also been observed that the version from NGINX that is available at origin.nodejs.org is being indexed in Google, so removing it should resolve this.

It should be called out that the dist, download, docs, api, etc. should still be served from NGINX.

The site build script can be removed, as well as various parts of the NGINX config relating to the serving of Next.js:

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/config/nodejs.org?plain=1#L114-L117

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/config/nodejs.org?plain=1#L124-L172

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/config/nodejs.org?plain=1#L264-L292

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/tasks/site-setup.yaml#L92

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/tasks/site-setup.yaml#L102

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/scripts/check-build-site.sh#L5-L6

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/scripts/build-site.sh#L7-L8

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/scripts/build-site.sh#L23-L26

I'm probably missing some other bits.

MattIPv4 avatar Feb 20 '24 18:02 MattIPv4

The first thing I can do is delete the website contents from the server. It's outdated now anyway. @nodejs/build-infra wdyt?

targos avatar Feb 21 '24 07:02 targos

👍 Not build infra, but removing the site content seems like a good first step and would solve for the Google indexing issue (and act as a confirmation we don't need it before removing all the code/config for building/serving it).

MattIPv4 avatar Feb 21 '24 16:02 MattIPv4

I moved all website files to a folder at /home/www/nodejs_old in case we need to recover something, and updated the robots.txt to disallow everything.

Remains:

$ ls nodejs
robots.txt  traffic-manager
$ cat nodejs/robots.txt
User-Agent: *
Disallow: /

targos avatar Feb 23 '24 14:02 targos

Opened https://github.com/nodejs/build/pull/3641 to remove the build scripts and webhook.

targos avatar Feb 24 '24 09:02 targos