Migrate away from 'master' as the jenkins CI controller node name

[sxa]

What is the problem this feature will solve?

Remove all references to 'master' in jenkins. We have made the changein default branch name in all our repositories so to be consistent we should switch the name in jenkins too. This is recommended by jenkins: https://www.jenkins.io/doc/book/managing/built-in-node-migration/

What is the feature you are proposing to solve the problem?

Click the migration button in jenkins to migrage from master to build-in as the controller's node. I don't think we have any executors on the controller host, so I suspect this will have no impactL

What alternatives have you considered?

Leaving it as-is and ignoring the warning :-)

[richardlau]

@sxa Did you mean to open this in https://github.com/nodejs/build instead?

[mhdawson]

Is there anything more needed than:

Click the migration button in jenkins to migrage from masger to build-in as the controller's node

Is there any risk in doing this?

[sxa]

Theorietcially it would depend if anything was explictly coded to 'master', although this is not likely to be aproblem given that

1. Node does not have any executors on the built-in node anyway
2. We could add the master label to another node if it became a problem

Based on the first of those, I'm pretty sure it would be safe for us.

[mhdawson]

ok, then +1 lets pick a time and do it.

[richardlau]

This may have been done when I updated the CI servers in https://github.com/nodejs/build/issues/2984.

[github-actions[bot]]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.