node-test-commit-windows-coverage-daily looks broken

[richardlau]

@nodejs/coverage-admins https://ci.nodejs.org/job/node-test-commit-windows-coverage-daily/ looks broken. e.g. https://ci.nodejs.org/job/node-test-commit-windows-coverage-daily/535/ ➡️ https://ci.nodejs.org/job/node-compile-windows/40368/ All compile subjobs fail:

"NODEJS_MAJOR_VERSION parameter (14) does not match output of tools\getnodeversion.py (17)"

so I imagine this has been broken since Node.js 15. Looks like NODEJS_MAJOR_VERSION doesn't get set for the compile job so defaults to 14 leading to the mismatch.

[github-actions[bot]]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

[richardlau]

ping @nodejs/coverage-admins again.

[Trott]

One way to resolve this issue would be to retire our Jenkins-generated coverage and rely on https://app.codecov.io/gh/nodejs/node which is generated by GitHub Actions.

[Trott]

One way to resolve this issue would be to retire our Jenkins-generated coverage and rely on https://app.codecov.io/gh/nodejs/node which is generated by GitHub Actions.

Argh, although I guess that would mean no C++ coverage reports?

[Trott]

Is the problem that an expectation of Node.js 14 is coded somewhere (maybe in an environment variable set by the job?) but running this on the master branch compiles Node.js 18 and the job errors because of that?:

20:01:43 > for /F "delims=." %a in ('python tools\getnodeversion.py') do if not "%a" == "14" (
20:01:43 echo "NODEJS_MAJOR_VERSION parameter (14) does not match output of tools\getnodeversion.py (%a)"  
20:01:43  exit /b 1 
20:01:43 ) 
20:01:43 
20:01:43 > if not "18" == "14" (
20:01:43 echo "NODEJS_MAJOR_VERSION parameter (14) does not match output of tools\getnodeversion.py (18)"  
20:01:43  exit /b 1 
20:01:43 ) 
20:01:43 "NODEJS_MAJOR_VERSION parameter (14) does not match output of tools\getnodeversion.py (18)"
20:01:43 

[Trott]

Yeah, looks like NODEJS_MAJOR_VERSION in the Jenkins job parameters is set to 14. We won't need to bump this every release of Node.js, will we? Is that something releasers do for other Jenkins jobs when there's a major release?

[richardlau]

Yeah, looks like NODEJS_MAJOR_VERSION in the Jenkins job parameters is set to 14. We won't need to bump this every release of Node.js, will we? Is that something releasers do for other Jenkins jobs when there's a major release?

You'll probably need to work out how node-test-commit-windows-fanned is setting and passing NODEJS_MAJOR_VERSION to node-compile-windows.

[Trott]

You'll probably need to work out how node-test-commit-windows-fanned is setting and passing NODEJS_MAJOR_VERSION to node-compile-windows.

It looks like it's hardcoded in the configuration seen at https://ci.nodejs.org/view/All/job/node-test-commit-windows-coverage-daily/configure.

[github-actions[bot]]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.