build
build copied to clipboard
nodejs
CI job request: daily coverage job without Intl
What do we all think about the idea of trying to set up a third test coverage job (to go along with the Linux one and the Windows one) to run Node.js compiled without Intl support? That would allow us to complete coverage in files like lib/internal/util/inspect.js.html. There's already a Jenkins job that does tests without Intl (https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/). I think we'd just need to modify it to do coverage, run nightly, and push results to the right place(s).
I assume it would just contribute the coverage to https://app.codecov.io/gh/nodejs/node, right? If so then I don't see any issue and seems like a good idea.
As I understand the current status on this one, there's an in progress attempt to do this as a GitHub action: https://github.com/nodejs/node/pull/37954
FWIW the Windows coverage job looks to have been broken for some time https://github.com/nodejs/build/issues/2645
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
@Trott can we close now that https://github.com/nodejs/node/pull/37954 has landed?
@Trott can we close now that nodejs/node#37954 has landed?
If there's consensus to abandon our own coverage in coverage.nodejs.org and rely on codecov.,io, then yes. If not, then we probably want to get it added to coverage.nodejs.org. I'm fine if you close this.
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.