Node-red-node-email (get) not dedected by Complete node

[DamianosS]

node-red-node-email 1.7.4
Node-RED v1.0.2

Hi, Node-RED team!

I have discovered that the node-red-node-email (email in) does not provide the complete status according to (https://nodered.org/blog/2019/09/20/node-done)

It would be helpful to have the complete status available. Even if the email in node has two options on how to start (automatic and triggered), it would be helpful in both cases to know when the node has completed its action.

IMO, the information could be:

- node triggered (either automatically every x seconds or manually)
- connect()
- fetch()
	if (email exists) deliver_content()
- done()	

Thanks!

[dceejay]

the node already emits status that can be caught by the status node. This includes errors. done is for reporting completed handling of incoming messages where you may need to know the incoming message. When set to triggered mode no part of the incoming message is used apart from the fact that it arrived to trigger the node.

[knolleary]

@dceejay if the email node can be triggered by it receiving a message, then it should call done when it finishes acting in response to that message. That's just how done works.

We introduced done because you cannot correlate a status update with what message caused the status update.

done is for reporting completed handling of incoming messages where you may need to know the incoming message.

So why doesn't that apply to the email node?

When set to triggered mode no part of the incoming message is used apart from the fact that it arrived to trigger the node.

That just make it even more important to use done - if none of the incoming message properties is preserved by the node, then without done it would be impossible to know what triggered the email node.