node-red-nodes icon indicating copy to clipboard operation
node-red-nodes copied to clipboard

node-red-contrib-heatmiser add support for neo

Open tvrulesme opened this issue 6 years ago • 5 comments

node-red-contrib-heatmiser has support only for wifi. node_modules already has neo.js so would it be possible to add neo support to node-red-contrib-heatmiser. More than happy to do any testing required.

I'm a bit of a nodejs novice but as a Java programmer happy to help out with the development side if useful.

Many thanks in advance

tvrulesme avatar Feb 16 '19 08:02 tvrulesme

Yes it is.

knolleary avatar Feb 16 '19 09:02 knolleary

Sorry, missed it and the contrib didn't help

hardillb avatar Feb 16 '19 09:02 hardillb

I was surprised to find it here - https://github.com/node-red/node-red-nodes/tree/master/hardware/heatmiser

Can't remember the history of why we ended up with a contrib node in this repo, but we do.

@tvrulesme whilst it is in this repo, it isn't one we actively maintain; we don't have the hardware to test any changes.

A pull-request that implemented the necessary changes would certainly help.

knolleary avatar Feb 16 '19 09:02 knolleary

Brilliant @knolleary Thanks a million. Happy to have a crack at the dev work myself. Will give it a try and PR when ready

tvrulesme avatar Feb 16 '19 09:02 tvrulesme

surprised - yes - me too. Must have been one of the very very early ones before we even had npm installable nodes.

dceejay avatar Feb 16 '19 09:02 dceejay