node-red-nodes icon indicating copy to clipboard operation
node-red-nodes copied to clipboard

Published 20 hours ago • verified publisher icon node-red

Mysql node update for holding query directly.

Open ryansh100 opened this issue 8 years ago • 4 comments

Update the mysql node to have a direct query input in the node configuration to free up the msg.topic.

I had a previous pull request out there that was discussed, but didn't pass the CLA because I had some commits without email address set.

This feature attempts to solve the lack of a direct input of SQL query into node instead of over-writing the topic.

Mutating the topic in the middle of a flow seemed very strange to me when using the mysql node.

ryansh100 avatar Apr 04 '17 03:04 ryansh100

Coverage Status

Coverage decreased (-0.1%) to 76.387% when pulling 4f2b5ea3511cbeeaf792a331152713befcbb89a9 on ryansh100:feature/mysql-node-input into a06ad8f1a743f347baa18de74d97a8aeb34b62ce on node-red:master.

coveralls avatar Apr 04 '17 04:04 coveralls

I think your coverage tool is not including files with no coverage at all.

ryansh100 avatar Apr 04 '17 04:04 ryansh100

👍! I'm fighting side effects from overwriting the topic right now

JustinAiken avatar May 30 '19 22:05 JustinAiken

Justin, would you find value in trying to get this actually merged in?

ryansh100 avatar Jun 04 '19 01:06 ryansh100