node-red-admin icon indicating copy to clipboard operation
node-red-admin copied to clipboard

let uiHost be set by security question in admin init. Beef up language around security question.

Open dceejay opened this issue 1 year ago • 1 comments

(force to 127.0.0.1 if no admin password)

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)

Proposed changes

This change beefs up the language about choosing a password... ie by adding " DO NOT select No if you will expose Node-RED to the internet - or you will be hacked!"

If the user then still selects no it then changes the uiHost setting to be 127.0.0.1 so that only the local browser can connect and edit by default.

This only happens when you run node-red admin init - so won't affect existing users.

In parallel - The Pi install script will change to always run admin init if there is no settings file (IE a clean install) - so it should now be almost mandatory for new (Pi/debian/ubuntu) users to set an admin password...

Checklist

  • [x] I have read the contribution guidelines
  • [x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • [x] I have run grunt to verify the unit tests pass
  • [ ] I have added suitable unit tests to cover the new/changed functionality

dceejay avatar Jan 05 '24 18:01 dceejay

Coverage Status

coverage: 81.563%. remained the same when pulling e3cdfbd609b8fe5cc055e57b4b01f0178193489c on add-uiHost-to-variables into cdbd0023f132561d346e781a61a627c022ed52f9 on master.

coveralls avatar Jan 05 '24 18:01 coveralls