node-oauth2-server

node-oauth2-server copied to clipboard

Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.1.1. Release notes Sourced from eslint's releases. v9.1.1 Bug Fixes a26b402 fix: use @​eslint/create-config latest (#18373) (唯然) v9.1.0 Features 03068f1 feat: Provide helpful error message...

dependabot[bot]

Does this library support user approval dialog during authorization code grant?

28

It seems AuthenticationHandler is to see who the user is from the request, not to show an additional dialog for explicit approval. Is it a supported flow?

saschanaz

`authenticate` endpoint still expects `scope` as a `string` instead of `string[]`

4

**Specify your setup** Irrelevant **Describe the bug** According to the [Documentation](https://node-oauthoauth2-server.readthedocs.io/en/master/api/oauth2-server.html#authenticate-request-response-options) and the Typescript typings, `OAuth2Server.authenticate` expects `options.scope`, which is of type `string[]`. However, in [authenticate-handler.js](https://github.com/node-oauth/node-oauth2-server/blob/master/lib/handlers/authenticate-handler.js#L50), this scope is passedd...

Valerionn

Bumps [readthedocs-sphinx-search](https://github.com/readthedocs/readthedocs-sphinx-search) from 0.1.1 to 0.3.2. Changelog Sourced from readthedocs-sphinx-search's changelog. Version 0.3.2 :Date: Jan 15, 2024 @​stsewd: Security fix, more information in GHSA-xgfm-fjx6-62mj <https://github.com/readthedocs/readthedocs-sphinx-search/security/advisories/GHSA-xgfm-fjx6-62mj>__. Version 0.3.1 :Date: Mar 27,...

dependabot[bot]

build(deps-dev): bump chai from 4.3.7 to 5.0.0

2

Bumps [chai](https://github.com/chaijs/chai) from 4.3.7 to 5.0.0. Release notes Sourced from chai's releases. v5.0.0 What's Changed feat: use chaijs/loupe for inspection by @​pcorpet in chaijs/chai#1401 docs: fix URL in README by...

dependabot[bot]

Contribution guidelines do not cover how to PR fixes for docs

2

The documentation does require to start PRs from `development`. However, the readthedocs.io always points to `master` and fixes for stable docs should therefore be made by pointing to master and...

jankapunkt

An option to require PKCE parameters

6

It seems it's fully optional right now: https://github.com/node-oauth/node-oauth2-server/blob/c993eb5a700f81fe204283b3428e0742015f9b8d/lib/grant-types/authorization-code-grant-type.js#L122-L144 Could be great if there's an option to force it. Of course one can block the request manually by checking the query,...

saschanaz

Improve documentation by adding jsDoc compatible method documentations

7

I found many functions lack of proper parameter descriptions, for example in `server.js`. Especially `options` are often completely undocumented.

jankapunkt

Host documentation on Github pages

6

We can easily host the docs on GH pages and we should to relfect our recent changes in the documentation, too.

jankapunkt

https://discord.gg/4HTUAcTvqV The Discord is not a replacement for the issue board, please do not use the discord for bug reporting.

HappyZombies