gradle-node-plugin icon indicating copy to clipboard operation
gradle-node-plugin copied to clipboard

Published 20 hours ago • verified publisher icon node-gradle

NodePlugin runs uname twice

Open adam-enko opened this issue 5 months ago • 1 comments

NodePlugin runs uname twice:

  • Once on line 90 (the result is unused)

    https://github.com/node-gradle/gradle-node-plugin/blob/7.1.0/src/main/kotlin/com/github/gradle/node/NodePlugin.kt#L90-L94

  • Again on lines 91-94

    https://github.com/node-gradle/gradle-node-plugin/blob/7.1.0/src/main/kotlin/com/github/gradle/node/NodePlugin.kt#L91-L94

Perhaps this is intentional, but I just wanted to double check, in case it was a mistake. If it's intentional I think it would help to add a comment to explain the purpose.

adam-enko avatar Jun 05 '25 08:06 adam-enko