formidable
formidable copied to clipboard
node-formidable
Maintainer Wanted
I haven't maintained this module in a while*, and PRs are piling up.
If anybody is interested in helping out, I'm happy to give commit bits + npm package access.
To get access, please try to write 1-2 sentences that give me a reasonable hope you're not looking to put malicious code into the package and also mention your npm account name.
* For those curious about the "why?", I'm working with Go these days haven't been using node.js for over 3 years now.
@pornel sounds good. What's your NPM account? I'll give you access :). Thanks!
I also can help when have time. I have Koajs package koa-better-body that uses formidable. It's about 3 years old and many users use it, and using it exactly because formidable.
I'm all-lowercased tunnckocore at npm.
Hi, @felixge
I'm happy to help as well. I have decent experience in creating and maintaining libraries, as well as packaging and releasing. @pornel, maybe you want someone to spar with?
@tunnckoCore added you on gh and npm.
@badeball added you only on gh since you didn't provide your npm handle.
@ all: Thank you so much for offering your help. I'll leave it up to you if you just want to merge good PRs, or add new features. A lot of people depend on this library, so big API changes are probably undesirable at this point. Anyway, I'll mostly stay out of it, unless you need my help to break a tie on a discussion or similar.
@felixge cool, thanks!
so big API changes are probably undesirable at this point.
Maybe yea. First we should try to clear the most issues.
We should add some more benchmarks against the other parsers like dicer and busboy, because I'm curious if formidable is still faster.
We should add some more benchmarks against the other parsers like dicer and busboy, because I'm curious if formidable is still faster.
I would expect newer libraries to be faster. I mean I wrote most of the parser 6 years ago, and a lot of things have changed in Node/v8 since then. There was also a lot of time to just improve on my initial ideas :).
Anyway, it would be interesting to see where things are at, but I'd be surprised if formidable wasn't "fast enough" anymore. If it can still process data faster than what your network interface on your server is rated for ... the code is probably fast enough :)
Yea exactly. In any way it is always good to have some comparison to know where we are. :)
Very important things should be done first. Sadly I don't have the time, but veryt hanks for that @felixge added me. I always trying to comment and help in new issues, but sadly I can't commit new things and fixes. I partially believe that this project deserve to be rewritten to be more accurate.
@blueelvis It woul dbe great if you can help with the issues and the commented on #414 and #415, because I'm very tired about the whole community and I'm in pause (for relax) currently and I'm not doing anything last few weeks or so (just rage quit).
I am Interested As I need this module so much in my file Storage System and I am using it now on it streamupbox, and is my NPM name too. thank you.
@richard457 I can't find you on npm?
$ npm owner add richard457 formidable
npm ERR! owner mutate Error getting user data for richard457
npm ERR! code E404
npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/-/user/org.couchdb.user:richard457
npm ERR! A complete log of this run can be found in:
@kornelski @felixge What's the status of this? I am confused a bit, given https://github.com/felixge/node-formidable/commit/d5ccbc40338d18e885c79668166e94be8db330e8#r21119456. Who is the primary maintainer of this package atm?
A company I work for uses this in production I'm rwky on npm we'd be happy to help out.
Has anyone actually looked through all of the outstanding PRs? For example, https://github.com/felixge/node-formidable/pull/267 is more than 4 years old and waiting on feedback from the original author about the appropriateness of adding the functionality to the library. The newest one in the queue is from May 2017, so just declaring bankruptcy (closing all PRs and asking users to test against the current version) might be appropriate.
@reviewher yes, I reviewed them much of them and thought for the same thing. Probably most of them are not related anymore.
Hi, I doesn't want this package to fall so I will gladly helps you to maintain this project alive! My npm account: quantumsheep
Hi. We use it (heavily) in few of our projects, and I myself have built a lot of code on top of it. It's a pity to see it not being maintained lately, as we want to reuse our existing code-base in a new long-term enterprise project. And the code-base was built on top of it, thus we need to maintain it.
Would be glad to help to keep it alive.
NPM account: https://www.npmjs.com/~xargs
@QuantumSheep @xarguments added both of you on GH / NPM. Thanks for helping!
@felixge would mind add few Github bots to the repo? Or perhaps moving the repo to org (sounds like a better way to go for the future)?
Dear @felixge,
would you mind adding your repo on maintainerswanted.com? It's open source 🌟 https://github.com/flxwu/maintainerswanted.com and will be launched 🚀 in the next few days.
Thank you! 🙏
Best regards, Felix
Yo @felixge can help up us a bit with moving the project to an organization?
I've just created it @node-formidable and I sent invites to most from here and to Felix.
@tunnckoCore sorry I missed your message about adding bots, I can help with that, just let me know what you need.
About transferring to an org: I'd be okay with that, but maybe you can share some more info on that? As far as I can tell @kornelski has been the most active on this repo lately, how does he feel about the org?
Orgs are more flexible in any way. It would be easier if we want to add some other contribs in the future, or adding new apps/bots to the repo, or separating some parts to other repos.
Yea, @kornelski is doing the most. I really want to update the DX and the docs.
I'm fine with an org. I'm spread thin with many projects, so whatever helps others to collaborate on this project is good.