mintrayr icon indicating copy to clipboard operation
mintrayr copied to clipboard

MinimizeToTray revived not working with Thunderbird 60

Open aindriu80 opened this issue 7 years ago • 67 comments

Hi, I just installed the latest version of Thunderbird and I am having trouble with MinimizeToTray. It wont work with version 60 :

2018-08-06 20_09_31-window

Options come up and you can select each of the radio buttons directly but no changes are save and you have to exit Thunderbird to get functionality back.

aindriu80 avatar Aug 06 '18 19:08 aindriu80

This addons seems basically abandoned (e.g. https://github.com/nmaier/mintrayr/pull/179 still not merged). I think we need a community fork.

qwertychouskie avatar Aug 06 '18 20:08 qwertychouskie

MinimizeToTray revived revived.

E: Last commit over 2 years ago: https://github.com/nmaier/mintrayr/commits/master. Tried some tray apps, but none seemed to work.

Det87 avatar Aug 19 '18 01:08 Det87

In case anyone is considering a fork or devoting some time into making just any tray add-on for Thunderbird 60+ work again, I am hereby cross-referencing FireTray issue 238.

s-m-e avatar Aug 19 '18 08:08 s-m-e

It doesn't work even if you set extensions.strictCompatibility=false.

marcoben73 avatar Sep 11 '18 13:09 marcoben73

My requirement is to not close the application when I click the close button (accidentally); I don't care about use tray icon or normal taskbar icon. My quick & dirty hack (I use KDE) is to remove the title bar for Thunderbird windows. https://www.reddit.com/r/kde/comments/6lwc1y/remove_titlebar/

marcoben73 avatar Sep 11 '18 13:09 marcoben73

Someone posted a working version of Firetray: https://github.com/foudfou/FireTray/issues/238#issuecomment-419705792

qwertychouskie avatar Sep 11 '18 18:09 qwertychouskie

Hi, I worked for a lot of hours to try to run this addon on Thunderbird 60.

Here is my repository: mintrayr: dev_thunderbird_60 + branch.

And the page on AMO, waiting for validation (hoping that it will be done quickly): https://addons.thunderbird.net/en-US/thunderbird/addon/minimizetotray-reanimated/ .

Can people test if my changes are working on all systems?

ysard avatar Sep 12 '18 13:09 ysard

Tested on Thunderbird 60.0 (Windows 10) and tray icon will not appear. Settings works but have no effect. Thunderbird logs contains following:

thunderbird-log

kolinger avatar Sep 12 '18 13:09 kolinger

@kolinger : Okay, thank you for testing, I do not have a computer under Windows at hand.

This goes back to what you said a few days ago on another post, the lack of unpacking of the application poses big problems with js-ctypes.

ysard avatar Sep 12 '18 13:09 ysard

Hi ysard. Tested on Gentoo / Fluxbox / Thunderbird 60.0 but no tray icon appears. The settings do not open either, throwing the error "No chrome package registered for chrome://mintrayr/content/prefs/prefs.xul". For reference I have been using FireTray [1] instead which is working.

Thanks for your work.

[1] https://github.com/firetray-updates/FireTray/tree/thunderbird-57

lbratch avatar Sep 12 '18 13:09 lbratch

@ysard Linux is different in this matter? This extension is using ctypes for linux too if I see correctly.

@lbratch Where is working version for download? I tried compile repository what did you sent. Resulting extension will install but settings nor tray icon works. Settings are broken and icon will not appear. I'm missing something?

kolinger avatar Sep 12 '18 13:09 kolinger

@kolinger : There may be a problem in the path that refers to the library to load (Windows folder separators are different from those used on Linux).

@lbratch : Ok thanks, this is more problematic...

I'm going to watch this tonight.

ysard avatar Sep 12 '18 14:09 ysard

@ysard Thanks for the fork! are you planning on just making the addon work or also add new features?If it is the latter maybe the most commented feature requests could be reopened in your tracker.

WPFilmmaker avatar Sep 12 '18 14:09 WPFilmmaker

Someone opened a ticket on bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1486221 perhaps people interested could comment and add their vote to it?

WPFilmmaker avatar Sep 12 '18 14:09 WPFilmmaker

@WPFilmmaker Unfortunately I'm already developing my own extension for Firefox Quantum (https://addons.mozilla.org/fr/firefox/addon/cookie-quick-manager/) and it takes me a lot of time; for now I'm trying to run this extension (and it runs on my computer ><) because Thunderbird is a must have software used daily and the space saving in the taskbar is essential.

However, I do not exclude working on an addon based on webextensions because all addons using js-ctypes are doomed to disappear.

ysard avatar Sep 12 '18 14:09 ysard

@ysard Thank you! It is understandable you are doing enough by keeping it alive.

Then the best hope is to get this integrated into TB. To others, as my previous comment says if you are interested go on bugzilla, comment and vote!

WPFilmmaker avatar Sep 12 '18 14:09 WPFilmmaker

@ysard I found the problem. Path for Windows was indeed broken. I did sent PR to your fork. Now it should work 🎉

kolinger avatar Sep 12 '18 15:09 kolinger

@ysard @kolinger Just installed the latest version from https://github.com/ysard/mintrayr/tree/dev_thunderbird_60+ on my Win10 and it seems to work like a charm! Thank you so much! :)

das-peter avatar Sep 13 '18 07:09 das-peter

I noticed a problem on Windows 7: The contextual menu supposed to be triggered after a right click is not displayed (if the option to displayed it is checked). Am i the only one? I had to tweak the code that calls the showPopup() method (in mintrayr.jsm) because it was not working, even on Linux, but there is a problem on Windows : no menu and no error is thrown.

ysard avatar Sep 13 '18 08:09 ysard

Yes. It is acting weirdly. Right click works only when Thunderbird window is not minimized. But even then its in weird position. It is aligned to right and bottom of screen. Not where icon/mouse is. Right click when Thunderbird is minimized does nothing. Log is indeed empty. Strange...

menu

kolinger avatar Sep 13 '18 09:09 kolinger

Idem, i am confused here... An issue is opened on my repository to avoid going out of the subject of this thread: https://github.com/ysard/mintrayr/issues/3

ysard avatar Sep 13 '18 13:09 ysard

Thanks very much to make it available again for TB 60+ :)

m1-development avatar Sep 14 '18 10:09 m1-development

I cannot seem to get this working. It installs fine, but doesn't seem to function. I had the predecessor installed prior to this, but got the "Quantum" update which feels like a giant step backwards and it quit working.

ghost avatar Sep 14 '18 19:09 ghost

@DemonfangArun : Ok, try to fully remove the addon and reinstall it. Maybe the folders have not been reset during the update.

Then, make the following combination of keys: Ctrl+Maj+J, maybe errors related to mintrayr are visible...

ysard avatar Sep 14 '18 20:09 ysard

@DemonfangArun : Ok, try to fully remove the addon and reinstall it. Maybe the folders have not been reset during the update.

Then, make the following combination of keys: Ctrl+Maj+J, maybe errors related to mintrayr are visible...

I ended up backdating thunderbird to 56 and canning updates. I installed it after the update, so it wouldn't be that.

ghost avatar Sep 14 '18 20:09 ghost

@DemonfangArun The changes were made for Thunderbird 60 and up. All changes since version 57 have been applied in the code. This is probably the reason of your problem. The manifest also specifies that the accepted minimum version of Thunderbird is 60 :)

ysard avatar Sep 14 '18 21:09 ysard

That was read in the wrong order methinks. I installed this on 60, after updating, and it didn't work. I then decided to go back to 56 and use the appropriate addon for that version.

ghost avatar Sep 14 '18 21:09 ghost

Understood; In this case the logs in the console can be quite informative for me :) If you reinstall this addon again, do not hesitate to create an issue on the github.

ysard avatar Sep 16 '18 21:09 ysard

+1 just CANNOT get this to work in Windows 10. So very frustrating

mfreeman-xtivia avatar Sep 17 '18 20:09 mfreeman-xtivia

@ysard I think, I found an issue

your updated Addon is not working for me. Thunderbirds console shows me the following NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIZipReader.open] - trayservice.jsm:75

I thing this happens, because i have a space in my user folder.

for example:

C:\Users\John Doe\AppData\Roaming\Thunderbird

I think, this causes the error.

It would be gread, if you could fix it in your next release.

Thanks

SeppiW avatar Sep 17 '18 21:09 SeppiW