fastcdc-rs icon indicating copy to clipboard operation
fastcdc-rs copied to clipboard

Problems with right-shift in Gear rollsum.

Open dbaarda opened this issue 4 years ago • 2 comments

This implementation copies another implementation that uses a right-shift in its Gear rollsum. This has problems I reported here;

https://github.com/ronomon/deduplication/issues/7

dbaarda avatar Feb 09 '21 03:02 dbaarda

I see that Joran closed the original issue, but regardless, I'm going to keep this open so that I can think about it more. I did not research this topic at all, merely read the paper once and translated the readily available implementation by Joran. Thank you for thinking about this and reporting it.

nlfiedler avatar Feb 10 '21 05:02 nlfiedler

In case you are interested, I've also just finished some testing and analysis of chunker algorithms inspired by FastCDC here;

https://github.com/dbaarda/rollsum-chunking/blob/master/RESULTS.rst

The insights gained from this prompted me to post some other observations and recommendations when using that implementation of FastCDC here;

https://github.com/ronomon/deduplication/issues/8

dbaarda avatar Feb 17 '21 12:02 dbaarda