django-bootstrap3-datetimepicker icon indicating copy to clipboard operation
django-bootstrap3-datetimepicker copied to clipboard

Modification of the option "language" to "locale"

Open FranBisquerra opened this issue 9 years ago • 5 comments
trafficstars

In the newer versions the option language has been renamed to locale, causing problems when rendering the script. I think that the only thing you have to do to solve this issue is change the key 'language' in your widgets.py for 'locale'. At line 103. Going from this: self.options['language'] = translation.get_language() to this: self.options['locale'] = translation.get_language()

FranBisquerra avatar Jan 05 '16 17:01 FranBisquerra

Any thoughts on how to fix this issue in a way that's source control friendly until your lovely fix is merged in?

ktel1218 avatar Mar 04 '16 19:03 ktel1218

The only way that I found is to do what I did that is in my repository, get that code :)! El mar 4, 2016 8:14 PM, "ktel1218" [email protected] escribió:

Any thoughts on how to fix this issue in a way that's source control friendly until your lovely fix is merged in?

— Reply to this email directly or view it on GitHub https://github.com/nkunihiko/django-bootstrap3-datetimepicker/issues/48#issuecomment-192421587 .

FranBisquerra avatar Mar 04 '16 23:03 FranBisquerra

could you submit a PR for this?

rhetr avatar Mar 19 '16 21:03 rhetr

I already did if I'm not wrong, but I dont think that this plugin is still being mainatined.. El 19 mar. 2016 22:02, "rhetr" [email protected] escribió:

could you submit a PR for this?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/nkunihiko/django-bootstrap3-datetimepicker/issues/48#issuecomment-198785572

FranBisquerra avatar Mar 19 '16 21:03 FranBisquerra

Hello? Is this still on? Why do all django-datetimewidget-whatevers decide to add unnecessary or weird unacceptable stuff to js-library-options all over the place? That is some weird trend, sorry...

ri0t avatar Mar 24 '16 16:03 ri0t